[python][sklearn] use __sklearn_is_fitted__() in all estimator fitness checks
#4654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
requested review from
chivee,
henry0312 and
shiyu1994
as code owners
shiyu1994
approved these changes
Oct 8, 2021
jameslamb
approved these changes
Oct 9, 2021
There was a problem hiding this comment.
because
_DaskLGBMModelis not inherited fromLGBMModel where__sklearn_is_fitted__()is defined
ahhhhhhh ok that makes sense to me! I found that line in dask.py with git grep 'fitted_', didn't even stop to think about where in the method resolution order it was being used.
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the discussion in #4636 (comment).
@jameslamb Seems that we cannot use
__sklearn_is_fitted__()hereLightGBM/python-package/lightgbm/dask.py
Line 1004 in 29857c8
because
_DaskLGBMModelis not inherited fromLGBMModelwhere__sklearn_is_fitted__()is definedLightGBM/python-package/lightgbm/dask.py
Line 995 in 29857c8
LightGBM/python-package/lightgbm/sklearn.py
Line 350 in 29857c8
I think we can address this during working on #3845.